-
-
Notifications
You must be signed in to change notification settings - Fork 10.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
React 0.12 warns with this.props.activeRouteHandler #445
Comments
Yeah, we are working on a release that is free of al the warnings, should On Friday, October 31, 2014, Marcus Vorwaller notifications@github.com
|
+1 Thanks for staying on top of this! DefaultRoute also produces: |
I just started learning react and I wanted to use react-router. I was trying to check if I can fix this compatibility issue with react 0.12 and as far as I've found the only problem is how you pass the props to the last component in the route. I don't have much practice with javascript to solve this so I hope you get with the solution! GL |
@rpflorence Hi! |
@Rustem We're planning on releasing a new version this weekend, assuming we can get the work done in time. |
Great work @mjackson! I speak for many when I say we are very thankful for your hard work! You, @rpflorence and all other contributers are doing a extraordinary job. Thank you! |
@abergs :) Thank you. It is very much appreciated! |
@mjackson Thank you from me as well :) Looking forward to the next release |
👍 |
Thanks for working on that, guys! |
Yes, thanks for |
For sure, guys, router saves so much time of groundcoding :) |
Thank you guys.... |
@svewag The |
v0.11 shipped! no more warnings. |
✨🔥✨ |
|
Thanks guys. Dropped in my 0.12 upgraded project and works like a charm. Appreciate the hard work and helpful docs. 🐣 🐥 🐤 |
Awesome work guys! Worked like a charm. |
The warning is:
Warning: This JSX uses a plain function. Only React components are valid in React's JSX transform.
More information here:
facebook/react#2436
I'd dive in more and try to fix it but is day one using React / react-router for me.
The text was updated successfully, but these errors were encountered: