Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React 0.12 warns with this.props.activeRouteHandler #445

Closed
marcus opened this issue Oct 31, 2014 · 20 comments
Closed

React 0.12 warns with this.props.activeRouteHandler #445

marcus opened this issue Oct 31, 2014 · 20 comments

Comments

@marcus
Copy link

marcus commented Oct 31, 2014

The warning is:
Warning: This JSX uses a plain function. Only React components are valid in React's JSX transform.

More information here:
facebook/react#2436

I'd dive in more and try to fix it but is day one using React / react-router for me.

@ryanflorence
Copy link
Member

Yeah, we are working on a release that is free of al the warnings, should
have a branch ready for people to test out next week

On Friday, October 31, 2014, Marcus Vorwaller notifications@github.com
wrote:

The warning is:
Warning: This JSX uses a plain function. Only React components are valid
in React's JSX transform.

More information here:
facebook/react#2436 facebook/react#2436

I'd dive more but is day one using React / react-router for me.


Reply to this email directly or view it on GitHub
#445.

@felixakiragreen
Copy link

+1 Thanks for staying on top of this!

DefaultRoute also produces: Warning: This JSX uses a plain function. Only React components are valid in React's JSX transform.

@carlosfvp
Copy link

I just started learning react and I wanted to use react-router. I was trying to check if I can fix this compatibility issue with react 0.12 and as far as I've found the only problem is how you pass the props to the last component in the route. I don't have much practice with javascript to solve this so I hope you get with the solution! GL

@Rustem
Copy link

Rustem commented Nov 12, 2014

@rpflorence Hi!
When you are going to release a new version ?

@mjackson
Copy link
Member

@Rustem We're planning on releasing a new version this weekend, assuming we can get the work done in time.

@abergs
Copy link
Contributor

abergs commented Nov 13, 2014

Great work @mjackson! I speak for many when I say we are very thankful for your hard work! You, @rpflorence and all other contributers are doing a extraordinary job. Thank you!

@mjackson
Copy link
Member

@abergs :) Thank you. It is very much appreciated!

@josebalius
Copy link

@mjackson Thank you from me as well :) Looking forward to the next release

@pxwise
Copy link

pxwise commented Nov 14, 2014

👍

@ryanflorence
Copy link
Member

@YourDeveloperFriend
Copy link

Thanks for working on that, guys!

@jedireza
Copy link

Yes, thanks for react-router 👍

@Rustem
Copy link

Rustem commented Nov 15, 2014

For sure, guys, router saves so much time of groundcoding :)

@svewag
Copy link

svewag commented Nov 21, 2014

Thank you guys....
@mjackson it seems the weekend plan did not fit ;) any new plans?

@mjackson
Copy link
Member

@svewag The new-api branch is code/feature-complete. Just need to update docs and cut a release, which we should definitely be able to do this weekend.

@ryanflorence
Copy link
Member

v0.11 shipped! no more warnings.

@jedireza
Copy link

✨🔥✨

@abergs
Copy link
Contributor

abergs commented Nov 24, 2014

:shipit: Yeey!

@pxwise
Copy link

pxwise commented Nov 25, 2014

Thanks guys. Dropped in my 0.12 upgraded project and works like a charm. Appreciate the hard work and helpful docs. 🐣 🐥 🐤

@josebalius
Copy link

Awesome work guys! Worked like a charm.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests