Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

generatePath bug when param has = on it #6171

Closed
sibelius opened this issue May 24, 2018 · 0 comments
Closed

generatePath bug when param has = on it #6171

sibelius opened this issue May 24, 2018 · 0 comments

Comments

@sibelius
Copy link
Contributor

sibelius commented May 24, 2018 •
edited
Loading

I've tried to use generatePath with the following parameter

Q29tcGxhaW50OjVhZjFhMDg0MzhjMTk1MThiMTdlOTQ2Yg==

and it became:

Q29tcGxhaW50OjVhZjFhMDg0MzhjMTk1MThiMTdlOTQ2Yg%3D%3D

how can I make it work as it does not change params?
sibelius added a commit to sibelius/react-router that referenced this issue May 24, 2018
@sibelius
test(core): add failing test to generatePath, see remix-run#6171
2fc814b
@sibelius sibelius mentioned this issue May 24, 2018
Merged
@timdorr timdorr closed this as completed May 25, 2018
timdorr pushed a commit that referenced this issue May 25, 2018
@sibelius @timdorr
test(core): add failing test to generatePath, see #6171 (#6172)
34412fd 
* test(core): add failing test to generatePath, see #6171

* fix(typo): fix typo on test

* Use the pretty option.

* Pretty in compiled function
@lock lock bot locked as resolved and limited conversation to collaborators Jul 24, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@timdorr @sibelius