Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[meta] 5.0.0 changelog #6643

Closed
KubaJastrz opened this issue Mar 18, 2019 · 10 comments
Closed

[meta] 5.0.0 changelog #6643

KubaJastrz opened this issue Mar 18, 2019 · 10 comments

Comments

@KubaJastrz
Copy link

There is no changelog entry for 4.4.0 and https://github.com/ReactTraining/react-router/releases/latest links to version 4.3.1.

@burnhamrobertp
Copy link

Further, despite a tagged 4.4.0 version here in github, the new version has not been published to npmjs. Not sure if this is intentional or not.

@danhilltech
Copy link

see #6630 (comment)

@timdorr timdorr changed the title [meta] 4.4.0 changelog [meta] 5.0.0 changelog Mar 18, 2019
@deavial

This comment has been minimized.

@wintercounter

This comment has been minimized.

@rally25rs
Copy link

Came here to open the same issue. Bumping to 5.x implies a breaking change, but the changelog has no mention of 5.0.0 so not sure if I will have to make any code changes in order to upgrade. 😕

@timdorr
Copy link
Member

timdorr commented Mar 19, 2019

See the release for now: https://github.com/ReactTraining/react-router/releases/tag/v5.0.0

@rally25rs
Copy link

It might be worth mentioning; I've seen this same thing before from monorepos (IIRC it was Jest) where the packages all need to be exactly the same version, but they use ranges in their dep ranges.

The bigger problem that it tends to cause (which was my issue w/ Jest) was that you can't actually pull older versions. If you say yarn add react-router-dom@4.2.0 then it will in turn depend on react-router@^4.2.0 which will actually then install react-router@4.3.1 or whatever is latest; not the version you actually wanted, nor the version that matches react-router-dom

It would be a good idea for all the packages to not have ^ ranges in their dependencies to each other, and instead lock them to the current specific version, and have a build/release script that bumps the versions across the board for all modules and the interconnected dependencies at the same time.

(recently I've got in the habit of just no longer using version ranges at all in any of my projects. they cause more problems than they solve.)

Anyway, thanks for the link! I always forget that "releases" is a page on github 😆

@timdorr
Copy link
Member

timdorr commented Mar 19, 2019

Yes, that's specifically why we released 5.0 and why #6644 exists.

@mjackson
Copy link
Member

Please see https://github.com/ReactTraining/react-router/releases/tag/v5.0.0 for the full 5.0.0 changelog. There is also a blog post that goes into a bit more detail.

tl;dr Just take your React Router 4 app and start using v5. No breaking changes.

Related: Let's move away from CHANGES.md and just log stuff in GitHub releases. No reason that file needs to be versioned with everything else, and it's just one more step for people who are trying to contribute.

@timdorr
Copy link
Member

timdorr commented Mar 21, 2019

I'm strongly in favor of that as well. We have changelog files in redux and react-redux which are just links to the releases page. And ever since GitHub added release-only watching of repos, it's basically the "right" way to do it.

@lock lock bot locked as resolved and limited conversation to collaborators May 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants