Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for react-router@5.0.0 #273

Merged
merged 2 commits into from
Apr 14, 2019
Merged

Conversation

cmfcmf
Copy link
Contributor

@cmfcmf cmfcmf commented Mar 18, 2019

This updates the package.json file to add compatibility with react-router@^5.0.0. Even though the major version of react-router changed, it is fully backwards compatible:

Despite the major bump, this is actually a minor release. It is fully backwards compatible with any project coming from 4.x. Sorry for the convenience. 😬

-- https://github.com/ReactTraining/react-router/releases/tag/v5.0.0

Further information: remix-run/react-router#6643

@sidag95
Copy link

sidag95 commented Mar 20, 2019

Can you please release alpha version if this is taking time to merge?

@mikecousins
Copy link

This will close #274.

@imjoshdean-tc
Copy link

This was spoken about in another issue, but is there any reason to have the peer dependency be on react-router vs react-router-dom? Currently if you use react-router-dom, which is what is recommend you do for browser based applications you get an unmet peer dependency warning from this package and it would be great to fix that.

@sidag95
Copy link

sidag95 commented Mar 27, 2019

Any updates on this issue? I have forked and merged @cmfcmf 's PR for now, but an official update would be great! Thanks

@cmfcmf
Copy link
Contributor Author

cmfcmf commented Mar 28, 2019

This was spoken about in another issue, but is there any reason to have the peer dependency be on react-router vs react-router-dom? Currently if you use react-router-dom, which is what is recommend you do for browser based applications you get an unmet peer dependency warning from this package and it would be great to fix that.

Wouldn't that mean that this package won't work with React Native? #194 and #148 indicate that it might be possible to get it working with React Native.

@imjoshdean-tc
Copy link

That is a question for @supasate for sure - is this meant to be for the browser or for native applications or both?

@supasate
Copy link
Owner

supasate commented Apr 1, 2019

This library uses Router component from react-router. I can't say about React Native because I don't use it, but, from #194, it seems to work.

@supasate
Copy link
Owner

supasate commented Apr 1, 2019

@cmfcmf Can you help rebase to resolve the conflict?

@genexu
Copy link

genexu commented Apr 1, 2019

I just try on react-router@^5.0.0 with connected-react-router@^6.3.2, it seem to be un-compatibility. didn't pass router store to child component.

After downgrade react-router and react-router-dom pacakge version (@^4.3.4) everything working fine again.

螢幕快照 2019-04-01 下午6 21 08

I'm trying to fix this issue and PR (If i'm not too busy), looking for any reply.

@cmfcmf
Copy link
Contributor Author

cmfcmf commented Apr 1, 2019

@cmfcmf Can you help rebase to resolve the conflict?

Done!

@vbartusevicius
Copy link

Any news on this?

@supasate supasate merged commit d327b90 into supasate:master Apr 14, 2019
@supasate
Copy link
Owner

Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants