-
Notifications
You must be signed in to change notification settings - Fork 593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for react-redux v7 #321
Conversation
Thanks for doing this. :) I am curious: what is the process like for merging PRs into this project? As somebody who has only been tangentially involved with open source projects in the past - I know quite little about how different projects operate. I'd love to learn a bit about how the decision-making works for a project like this. |
@thisissami TBH I don't know. I believe that this project is a personal project of @supasate. According to old, similar PRs (like: #273) it looks like this awesome guy is maintaining the repo by his own. And kudos to him! Protip that I could give you - if you are ever curious how the contribution in open-source project works, check old PRs and |
Hey @quarties, awesome job! I think maybe it's a good idea to update the readme as well. currently it says that reac-redux@7 is not supported, which is exactly what this PR is about. |
Thank you for this @quarties. Just to confirm, is it safe to bump the version without further changes? I came across the following in the
Though that's from v6.0 so hopefully that's been resolved since then? |
@bboydflo good point, I had updated the README.md file as well. @janklimo I hope so too, I've tested my fork with upgraded I believe if there is anything else that we would need to check, @supasate will point it. |
Tested and working! LGTM! |
Thanks @quarties for working on this and thanks everyone for helping test it. I'm just relocated to another country and messing up with documents, banking, home hunting, new workplace, etc. So, let me merge and release this over the weekend. |
@supasate take your time, you are doing great work anyway! Good luck with post-relocation issues <3 |
@supasate any news on this? |
Released with v6.5.0. |
I know that it is a duplicate of #303, but it looks like the author of that PR is not currently available, so I decided to create my own.
With current dependenciec all test are passed :-)