-
Notifications
You must be signed in to change notification settings - Fork 593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support react-redux@7 #303
Conversation
Looks like the |
I'm going to update this PR and mark it as ready once a new version of |
Looks like new version of react-redux was released a couple of days ago. Would be great to get this in. |
They only released alpha versions. I'd like to wait for a non-alpha release. |
I just meet this issue today, I use lerna to controll all packages deps, and create new react app, And face connectedRouter context missing, maybe we should add Notice on Readme before compatible version has been release. |
@cmfcmf Thanks for all your time making this PR. Hopefully react-redux will not be long in being updated |
Hi folks! There is a new version of react-redux available (v7.1.0) :-) cc @cmfcmf |
Yes, @cmfcmf the 7.1 release is live so I think you can make your PR non-draft now |
This adds support for react-redux@7 and will close #287.
Two tests are failing right now, namely the ones that use a custom context. This happens due to a behavioral change (I'm unsure if its a bug) in react-redux, which I reported in reduxjs/react-redux#1278
connected-react-router/test/ConnectedRouter.test.js
Lines 108 to 124 in c5eebfc
connected-react-router/test/ConnectedRouter.test.js
Lines 229 to 245 in c5eebfc