Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v5 to v6 upgrade guide should mention that usePrompt and <Prompt> have been removed #8330

Closed
evoyy opened this issue Nov 13, 2021 · 5 comments · Fixed by #8436
Closed

v5 to v6 upgrade guide should mention that usePrompt and <Prompt> have been removed #8330

evoyy opened this issue Nov 13, 2021 · 5 comments · Fixed by #8436
Labels
feature

Comments

@evoyy
Copy link

evoyy commented Nov 13, 2021

What is the new or updated feature that you are suggesting?

There is no mention in the v5 to v6 upgrade guide that <Prompt> has been removed.

Why should this feature be included?

I discovered the following in the release notes for v6.0.0-beta.7:

We removed useBlocker(), usePrompt(), and <Prompt> for now. We will revisit these post 6.0 when we have more time to get it right.

It might be a good idea to mention this at the beginning of the guide because people who are using <Prompt> are unable to upgrade to v6 at the moment.
@evoyy evoyy added the feature label Nov 13, 2021
@evoyy evoyy changed the title v5 to v6 upgrade guide should mention that <Prompt /> has been removed v5 to v6 upgrade guide should mention that usePrompt and <Prompt> have been removed Nov 13, 2021
@pcb-unit pcb-unit mentioned this issue Nov 15, 2021
Open
@pluma
Copy link

pluma commented Nov 21, 2021

It would be nice if this was mentioned in the API docs too. I realize the URL indicates they're the v5 docs but the link to them suggests they're also the v6 docs and staring at it trying to figure out why the import no longer works isn't a fun way to find out about this change.

@minnyww
Copy link

minnyww commented Nov 23, 2021

anyone know how can block navigation in v6 ?

@rmorse
Copy link

rmorse commented Nov 24, 2021

I'm in need of this too - I tried looking though the code but I can't find anything that would allow me to do something before navigation (like blocking)...

@pluma
Copy link

pluma commented Nov 24, 2021

FWIW I've decided to use this opportunity to migrate from RRv5 to Next since the move to RRv6 would already involve a number of breaking changes.

petersendidit added a commit to petersendidit/react-router that referenced this issue Dec 2, 2021
@petersendidit
Note that <Prompt> support is missing from v6
0dedcf1 
Many code bases use the `<Prompt>` component from v5 but don't find out that support is currently missing from v6 until after attempting to upgrade.  This adds this information to the upgrade guide so that is more likely that I would be discovered before lots of effort is invested. 

Fixes remix-run#8330
@petersendidit petersendidit mentioned this issue Dec 2, 2021
Merged
@ylin0811
Copy link

Is there an eta on bringing up the usePrompt with 6.2.x? Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Note that <Prompt> support is missing from v6 petersendidit/react-router
5 participants
@rmorse @pluma @evoyy @minnyww @ylin0811