Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(router): "hard" redirect to different paths on the same origin if redirect location does not contain basename #10076

Merged
merged 6 commits into from
Feb 22, 2023
Merged

fix(router): "hard" redirect to different paths on the same origin if redirect location does not contain basename #10076

merged 6 commits into from
Feb 22, 2023

Conversation

amsal
Copy link
Contributor

@amsal amsal commented Feb 8, 2023

Fix for #10052

Checks whether the redirect location contains the basename (if set) and redirect as an external url if the basename is not present in the redirect location.

Also related: #9859

@changeset-bot
Copy link

changeset-bot bot commented Feb 8, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: d996f1e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@remix-run/router Patch
react-router Patch
react-router-dom Patch
react-router-dom-v5-compat Patch
react-router-native Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@amsal amsal mentioned this pull request Feb 8, 2023
Closed
@timdorr
Copy link
Member

timdorr commented Feb 9, 2023

This should include a test or two.

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Feb 9, 2023

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

@amsal amsal deleted the branch remix-run:release-next February 9, 2023 13:28
@amsal amsal closed this Feb 9, 2023
@amsal amsal deleted the dev branch February 9, 2023 13:28
@amsal amsal restored the dev branch February 9, 2023 13:28
@amsal amsal reopened this Feb 9, 2023
@tomfridental1
Copy link

tomfridental1 commented Feb 13, 2023 •
edited
Loading

Any eta on this? We facing the same issue: (

@brophdawg11 brophdawg11 self-assigned this Feb 16, 2023
@brophdawg11 brophdawg11 changed the base branch from dev to release-next February 22, 2023 16:13
@brophdawg11 brophdawg11 merged commit 0e6b2d9 into remix-run:release-next Feb 22, 2023
@brophdawg11 brophdawg11 linked an issue Feb 22, 2023 that may be closed by this pull request
[Bug]: absolute redirect fails while using base url #10052
Closed
@mcansh mcansh mentioned this pull request Feb 22, 2023
Merged
@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version 6.8.2-pre.2 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@amsal amsal deleted the dev branch February 23, 2023 22:23
@mcansh mcansh mentioned this pull request Feb 27, 2023
Merged
@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version 6.8.2 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brophdawg11 brophdawg11 brophdawg11 approved these changes

Assignees

@brophdawg11 brophdawg11

Labels
CLA Signed router
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: absolute redirect fails while using base url
5 participants
@amsal @timdorr @tomfridental1 @brophdawg11 @MichaelDeBoey