-
-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hotfix: absolute URLs on server router #10112
Hotfix: absolute URLs on server router #10112
Conversation
🦋 Changeset detectedLatest commit: 7244657 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Hi @thomasverleye, Welcome, and thank you for contributing to React Router! Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once. You may review the CLA and sign it by adding your name to contributors.yml. Once the CLA is signed, the If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at hello@remix.run. Thanks! - The Remix team |
Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳 |
Any ideas when this will get merged/released, @brophdawg11? |
…igin of absolute url
Thanks @thomasverleye! |
🤖 Hello there, We just published version Thanks! |
🤖 Hello there, We just published version Thanks! |
Currently, when rendering a
<Link to="mailto:foo@baz.com" />
in a server context, thehref
does not get rendered correctly.See following PR in Remix for failing test: remix-run/remix#5498
I've created an additional test with
<StaticRouter>
in the tests of the react-router-dom tests which passes with this fix 🍾Also fixes: #10094