-
-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(react-router-dom): fix detectErrorBoundary
function
#10190
Conversation
🦋 Changeset detectedLatest commit: 63fc751 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Hi @vonagam, Welcome, and thank you for contributing to React Router! Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once. You may review the CLA and sign it by adding your name to contributors.yml. Once the CLA is signed, the If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at hello@remix.run. Thanks! - The Remix team |
Can you add a test for this so we don't have a regression later? |
a7b5e1f
to
b9b7c53
Compare
Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳 |
I changed some places in existing tests to use |
detectErrorBoundary
function
b9b7c53
to
511840c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @vonagam! Just one comment for the unit test updates
packages/react-router-dom/__tests__/data-static-router-test.tsx
Outdated
Show resolved
Hide resolved
511840c
to
1284fd4
Compare
Thanks @vonagam! This looks good - do you mind just rebasing/repointing this to |
1284fd4
to
63fc751
Compare
Thanks! |
Check for presence of new
ErrorBoundary
property was missing.