fix inadvertent re-renders when using Component instead of element

[brophdawg11]

Closes #10283

[changeset-bot]

🦋 Changeset detected

Latest commit: 283aa48

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages

Name	Type
@remix-run/router	Patch
react-router	Patch
react-router-dom	Patch
react-router-dom-v5-compat	Patch
react-router-native	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[markdalgleish]

I feel like this name could be clearer, e.g. resolveRouteProperties, resolveCustomRouteProperties?

[brophdawg11]

Definitely open to bike-shedding here. I kinda like indicating that this function is what takes us from framework-agnostic to framework-aware. resolveFrameworkAwareRouteProperties is a mouthful though 😕 . resolveRouteFrameworkProperties or resolveRouteRenderProperties maybe?

Do you think the word "resolve" carries an incorrect connotation that this is how route.lazy stuff gets applied? That's not quite correct since this is a second pass after we apply the route.lazy props.

Longer term, I could even see a future where we decide that Component/ErrorBoundary are framework-agnostic enough (in todays component-based framework landscape, and as opposed to element/errorElement which felt super react-specific) and maybe we just type them as any in the router and that would eliminate hasErrorBoundary entirely. Then we overload the types in the router layer with React.Component etc.

[brophdawg11]

This could also be a future flag, but it's an implementation detail of RR and only newly (6.9.0) public API in @remix-run/router so on the fence as to whether it's worth a formal future flag?

[brophdawg11]

Bikeshedded and currently thinking mapRouteProperties

[github-actions]

🤖 Hello there,

We just published version 6.11.0-pre.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

[github-actions]

🤖 Hello there,

We just published version 6.11.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!