Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial-load fetchers should not automatically revalidate on GET navigations #10688

Merged
merged 4 commits into from
Jul 11, 2023

Conversation

brophdawg11
Copy link
Contributor

Follow up to #10623 which inadvertently started revalidating initial-load fetchers on GET navigations, when it should only revalidate (without calling shouldRevalidate) on explicit revalidations (submissions, useRevalidate, etc.).

Discord thread in which this was raised: https://discord.com/channels/770287896669978684/1128075241579614208/1128080680417501215

@changeset-bot
Copy link

changeset-bot bot commented Jul 11, 2023

🦋 Changeset detected

Latest commit: a666ed2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@remix-run/router Patch
react-router Patch
react-router-dom Patch
react-router-dom-v5-compat Patch
react-router-native Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@brophdawg11 brophdawg11 merged commit 058be38 into dev Jul 11, 2023
@brophdawg11 brophdawg11 deleted the brophdawg11/fetcher-initial-load-revalidation branch July 11, 2023 20:27
@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version 6.14.2-pre.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version 6.14.2 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant