Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add method and URL to aborted query/queryRoute error message #10793

Merged
merged 1 commit into from
Aug 16, 2023

Conversation

brophdawg11
Copy link
Contributor

Enhance error messages so folks know which routes they are happening on

@changeset-bot
Copy link

changeset-bot bot commented Aug 16, 2023

🦋 Changeset detected

Latest commit: af3e6d4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@remix-run/router Patch
react-router Patch
react-router-dom Patch
react-router-dom-v5-compat Patch
react-router-native Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@@ -66,6 +66,8 @@ describe("a hash history", () => {
});

it("prefixes raw hash values with /", () => {
let spy = jest.spyOn(console, "warn").mockImplementation(() => {});
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clear up some unintended output during unit tests

@brophdawg11 brophdawg11 merged commit 2208703 into dev Aug 16, 2023
3 checks passed
@brophdawg11 brophdawg11 deleted the brophdawg11/aborted-error-message branch August 16, 2023 14:19
@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version 6.16.0-pre.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version 6.16.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant