Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export ShouldRevalidateFunctionArgs interface #10797

Merged

Conversation

juanpprieto
Copy link
Contributor

@juanpprieto juanpprieto commented Aug 17, 2023

export ShouldRevalidateFunctionArgs so that it can be later exported also in @remix-run/react.

This would allow to export shouldRevalidate as a non arrow function in Remix

import type {ShouldRevalidateFunctionArgs} from '@remix-run/react'

export function shouldRevalidate(args: ShouldRevalidateFunctionArgs) {...}

@changeset-bot
Copy link

changeset-bot bot commented Aug 17, 2023

🦋 Changeset detected

Latest commit: 468679f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
react-router-dom-v5-compat Patch
react-router-native Patch
react-router-dom Patch
react-router Patch
@remix-run/router Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@juanpprieto juanpprieto changed the base branch from main to dev August 17, 2023 20:37
@brophdawg11 brophdawg11 merged commit ae75cdc into remix-run:dev Aug 18, 2023
3 checks passed
@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version 6.16.0-pre.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version 6.16.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants