-
-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add useFetcher(key) and <Form navigate={false}> #10960
Conversation
🦋 Changeset detectedLatest commit: 2c6b70a The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
2fbf8ff
to
95b8dd0
Compare
*/ | ||
export const Form = React.forwardRef<HTMLFormElement, FormProps>( | ||
(props, ref) => { | ||
let submit = useSubmit(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now that we're back to one useSubmit
method, we don't need this abstraction anymore - a fetcher can just use <Form navigate={false} fetcherKey={fetcherKey}>
internally 😍
/** | ||
* Returns the implementation for fetcher.submit | ||
*/ | ||
function useSubmitFetcher( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moved back into useSubmit
with the new navigate:false
option
let submit = useSubmitFetcher(fetcherKey, routeId); | ||
let [fetcherKey, setFetcherKey] = React.useState<string>(key || ""); | ||
if (!fetcherKey) { | ||
setFetcherKey(getUniqueFetcherId()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be a more concurrent-mode resilient way to assign ids
return [...state.fetchers.values()]; | ||
return Array.from(state.fetchers.entries()).map(([key, fetcher]) => ({ | ||
...fetcher, | ||
key, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Expose the key on useFetchers
for easier lookups
5a17ffe
to
2c6b70a
Compare
🤖 Hello there, We just published version Thanks! |
🤖 Hello there, We just published version Thanks! |
Add
useFetcher({ key })
and<Form navigate={false} fetcherKey={key}>
APIs