Allow persisted fetchers unmounted during submit to revalidate #11102
Conversation
🦋 Changeset detectedLatest commit: 8c508d8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| dfd.resolve("FETCH"); | ||
| await waitFor(() => screen.getByText("Num fetchers: 0")); | ||
| expect(getHtml(container)).toMatch("Page (1)"); | ||
| expect(getHtml(container)).toMatch("Page (2)"); |
There was a problem hiding this comment.
This test was incorrect before due to the bug. The revalidation would cause the count to increment again after the navigation completed
| if (deletedFetchers.has(key)) { | ||
| updateFetcherState(key, getDoneFetcher(undefined)); | ||
| return; | ||
| } |
There was a problem hiding this comment.
This was too aggressive. It works for handleFetcherLoader because there's nothing left to do for an unmounted fetcher. For submissions we only want to short circuit for error/redirects - we need to let success results flow through so revalidation happens.
There was a problem hiding this comment.
Easiest to see the changes with whitespace ignored
brophdawg11
deleted the
brophdawg11/submitting-fetcher-persist-revalidation
branch
|
🤖 Hello there, We just published version Thanks! |
|
🤖 Hello there, We just published version Thanks! |
Closes #11101