Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix useLocation to receive 0 instead of null when state is set to 0 #11451

Closed
wants to merge 5 commits into from

Conversation

jungwoo3490
Copy link
Contributor

Fixes #11448

I fixed location's state property value like this.

let location: Location = {
  pathname: locationProp.pathname || "/",
  search: locationProp.search || "",
  hash: locationProp.hash || "",
  state: locationProp.state ? locationProp.state === 0 ? 0 : locationProp.state : null, // fixed
  key: locationProp.key || "default",
};

Now, useLocation receive 0 instead of null when state is set to 0.

Copy link

changeset-bot bot commented Apr 15, 2024

⚠️ No Changeset found

Latest commit: 2cbb43f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Apr 15, 2024

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

@timdorr
Copy link
Member

timdorr commented Apr 16, 2024

Can you remove the unrelated import changes?

@jungwoo3490
Copy link
Contributor Author

Can you remove the unrelated import changes?

Sure!! I removed all of them :) @timdorr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants