Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix some comments #11886

Merged
merged 1 commit into from
Jan 7, 2025
Merged

chore: fix some comments #11886

merged 1 commit into from
Jan 7, 2025

Conversation

pwdcd
Copy link
Contributor

@pwdcd pwdcd commented Aug 14, 2024

No description provided.

Copy link

changeset-bot bot commented Aug 14, 2024

⚠️ No Changeset found

Latest commit: 4f7399c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Aug 14, 2024

Hi @pwdcd,

Welcome, and thank you for contributing to React Router!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at hello@remix.run.

Thanks!

- The Remix team

@brophdawg11
Copy link
Contributor

Thank you! Would you mind signing the CLA so we can get this merged?

@pwdcd
Copy link
Contributor Author

pwdcd commented Aug 15, 2024

Thank you! Would you mind signing the CLA so we can get this merged?

Of course. Signed.

Please review again

@timdorr
Copy link
Member

timdorr commented Aug 15, 2024

You need to add your username to the contributors.yml file. That is how we track signatures.

Signed-off-by: pwdcd <pwdcd@icloud.com>
@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Jan 7, 2025

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

@pwdcd
Copy link
Contributor Author

pwdcd commented Jan 7, 2025

You need to add your username to the contributors.yml file. That is how we track signatures.

Sorry it took so long to process. The conflict has been resolved and the username has been added to the contributors.yml file.

Please review again.

@timdorr
Copy link
Member

timdorr commented Jan 7, 2025

Tanks!

@timdorr timdorr merged commit 3d40930 into remix-run:main Jan 7, 2025
1 check passed
Copy link
Contributor

🤖 Hello there,

We just published version 7.1.2-pre.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Copy link
Contributor

🤖 Hello there,

We just published version 6.28.3-pre-v6.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@brophdawg11
Copy link
Contributor

bad bot - this is definitely not in 6.28.3-pre-v6.0 😂 . It looks like something about our logic for identifying included issues doesn't work for our v6 releases from the v6 branch so I'm going to disable this commenting for v6 releases going forward

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants