-
-
Notifications
You must be signed in to change notification settings - Fork 10.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: fix some comments #11886
chore: fix some comments #11886
Conversation
|
Hi @pwdcd, Welcome, and thank you for contributing to React Router! Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once. You may review the CLA and sign it by adding your name to contributors.yml. Once the CLA is signed, the If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at hello@remix.run. Thanks! - The Remix team |
Thank you! Would you mind signing the CLA so we can get this merged? |
Of course. Signed. Please review again |
You need to add your username to the contributors.yml file. That is how we track signatures. |
Signed-off-by: pwdcd <pwdcd@icloud.com>
Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳 |
Sorry it took so long to process. The conflict has been resolved and the username has been added to the contributors.yml file. Please review again. |
Tanks! |
🤖 Hello there, We just published version Thanks! |
🤖 Hello there, We just published version Thanks! |
bad bot - this is definitely not in 6.28.3-pre-v6.0 😂 . It looks like something about our logic for identifying included issues doesn't work for our v6 releases from the v6 branch so I'm going to disable this commenting for v6 releases going forward |
No description provided.