fix(react-router): remove cyclic dependency #12133
Conversation
🦋 Changeset detectedLatest commit: 7a5ed6e The changes in this PR will be included in the next version bump. This PR includes changesets to release 10 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Hi @redabacha, Welcome, and thank you for contributing to React Router! Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once. You may review the CLA and sign it by adding your name to contributors.yml. Once the CLA is signed, the If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at hello@remix.run. Thanks! - The Remix team |
|
Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳 |
MichaelDeBoey
changed the title
MichaelDeBoey
changed the title
redabacha
force-pushed
the
fix-self-dep
branch
from
07dc768 to
06ecf5a
Compare
| "paths": { | ||
| "react-router": ["./index.ts"] | ||
| } |
There was a problem hiding this comment.
this is to make the rollup typescript plugin happy
| paths: { | ||
| "react-router": "./index.mjs", | ||
| }, |
There was a problem hiding this comment.
we rewrite the imports of react-router in the dom-export build to the most appropriate react-router entrypoint.
| // Pre-bundle router dependencies to avoid router duplicates. | ||
| // Mismatching routers cause `Error: You must render this element inside a <Remix> element`. | ||
| "react-router", | ||
| "react-router/dom", |
There was a problem hiding this comment.
this should've been here already 🤷♂️
|
closed in favor of #12136 |
2 participants
the prerelease version of react-router has a dependency on itself in the package.json which breaks some analysis tools (and also deno apparently 🙈). this pr removes that self-dependency and updates the imports used across the package to point to the same places as before.