-
-
Notifications
You must be signed in to change notification settings - Fork 10.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(react-router): (v7) fix static prerender non-ascii problem #12161
Conversation
🦋 Changeset detectedLatest commit: 33a0c0d The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Hi @saengmotmi, Welcome, and thank you for contributing to React Router! Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once. You may review the CLA and sign it by adding your name to contributors.yml. Once the CLA is signed, the If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at hello@remix.run. Thanks! - The Remix team |
Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳 |
Hello @timdorr, It looks like only the msedge runner failed, while firefox and webkit passed without any issues. Since there were no relevant changes to the code, it might just be an intermittent runner issue. Would you mind re-running the tests? Thank you! (it's fine in my local) ![]() |
Thank you @saengmotmi for the contribution! |
🤖 Hello there, We just published version Thanks! |
🤖 Hello there, We just published version Thanks! |
🤖 Hello there, We just published version Thanks! |
🤖 Hello there, We just published version Thanks! |
🤖 Hello there, We just published version Thanks! |
fix #12160
Screenshot 1: Attempted static prerendering, which failed.
Screenshot 2: Used
console.log
to inspect therequestInit
object insideprerenderRoute
to identify the point where prerendering fails.Screenshot 3: Confirmed that the non-ASCII data is correctly passed to the loader after applying
encodeURI
/decodeURI
.