Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(react-router): (v7) fix static prerender non-ascii problem #12161

Merged
merged 4 commits into from
Nov 12, 2024

Conversation

saengmotmi
Copy link
Contributor

@saengmotmi saengmotmi commented Oct 20, 2024

fix #12160

  • Fixed an issue where builds would fail during static prerendering in React Router v7 when the data passed to the loader contains non-ASCII characters, such as Korean.
  • Applied encodeURI to the X-React-Router-Prerender-Data header when making requests to localhost in the loader, and added decodeURI processing on the receiving end.
  • Added relevant tests and confirmed that they pass.

Screenshot 1: Attempted static prerendering, which failed.

image

Screenshot 2: Used console.log to inspect the requestInit object inside prerenderRoute to identify the point where prerendering fails.

image

Screenshot 3: Confirmed that the non-ASCII data is correctly passed to the loader after applying encodeURI/decodeURI.

image

Copy link

changeset-bot bot commented Oct 20, 2024

🦋 Changeset detected

Latest commit: 33a0c0d

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Oct 20, 2024

Hi @saengmotmi,

Welcome, and thank you for contributing to React Router!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at hello@remix.run.

Thanks!

- The Remix team

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Oct 20, 2024

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

@saengmotmi
Copy link
Contributor Author

saengmotmi commented Nov 2, 2024

Hello @timdorr,

It looks like only the msedge runner failed, while firefox and webkit passed without any issues. Since there were no relevant changes to the code, it might just be an intermittent runner issue. Would you mind re-running the tests?

Thank you!


(it's fine in my local)

image

@jacob-ebey jacob-ebey merged commit 2787855 into remix-run:dev Nov 12, 2024
8 checks passed
@jacob-ebey
Copy link
Member

Thank you @saengmotmi for the contribution!

Copy link
Contributor

🤖 Hello there,

We just published version 7.0.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Copy link
Contributor

🤖 Hello there,

We just published version 6.28.1-pre.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Copy link
Contributor

🤖 Hello there,

We just published version 6.28.1 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Copy link
Contributor

🤖 Hello there,

We just published version 7.1.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Copy link
Contributor

🤖 Hello there,

We just published version 6.28.2-pre.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants