bug: patchRoutesOnNavigation throws without triggering an error boundary #12493
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I encountered a TypeError when my
patchRoutesOnNavigation
function threw an error but there were no partial matches. I tracked the error down to this code inpackages/react-router/lib/router/router.ts
:The problem is that
findNearestBoundary
can returnundefined
, but it's typed as returningAgnosticDataRouteMatch
. I was able to reproduce the bug in a test (the first commit on this branch).Notice the
Cannot read properties of undefined
error in the failing tests.The reason this matters is that the error boundary does not get triggered in this case.