Skip to content

Conversation

@ryanflorence
Copy link
Member

pinterest example almost works now, just need to
add the omitted path searching to the route
matching.

this isn’t sending the state to transition hooks
but totally should

@ryanflorence ryanflorence force-pushed the next-transitionState branch 2 times, most recently from d50060f to 8d5226a Compare June 6, 2015 05:37
@ryanflorence
Copy link
Member Author

I like transitionState the most.

  • request has a lot of prior meaning we'd be swimming up stream to explain to people
  • transitionContext has a little bit of prior meaning with context in React, and its not quite the same
  • transitionInfo I like but ...
  • transitionState completely mirrors the ignored state feature of pushState, just state would be a good name outside of React, but inside of React I like the transition prefix. I don't think it will take as much to understand as the other names.

@agundermann
Copy link
Contributor

transitionState makes most sense to me, too.

Another one:

@mjackson
Copy link
Member

mjackson commented Jun 7, 2015

What if we just kept it on location.state ? key would be part of this.

@agundermann
Copy link
Contributor

Just calling it state might be a bit confusing since this is different from history.state and key (used one time only instead of being persisted). I imagine we might want to add a persistent state (built on top of key) in the future.

pinterest example almost works now, just need to
add the omitted path searching to the route
matching.

this isn’t sending the state to transition hooks
but totally should
@ryanflorence ryanflorence force-pushed the next-transitionState branch from 8d5226a to 416c802 Compare June 7, 2015 20:29
@ryancole
Copy link

ryancole commented Jun 8, 2015

Does this relate to the issue regarding the static transition functions not being able to make use of non-singleton flux stores on props, etc?

@mjackson mjackson deleted the next-transitionState branch June 13, 2015 23:45
@lock lock bot locked as resolved and limited conversation to collaborators Jan 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants