-
-
Notifications
You must be signed in to change notification settings - Fork 10.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dedup route modules types across server-runtime and ssr #12799
Conversation
🦋 Changeset detectedLatest commit: 50d24f5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 11 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
*/ | ||
export type RouteHandle = unknown; | ||
|
||
export interface EntryRouteModule { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed - was a dup of RouteModule
in the ssr
version
export interface RouteModules<RouteModule> { | ||
[routeId: string]: RouteModule | undefined; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unused as far as I can tell
export type HeadersArgs = { | ||
loaderHeaders: Headers; | ||
parentHeaders: Headers; | ||
actionHeaders: Headers; | ||
errorHeaders: Headers | undefined; | ||
}; | ||
|
||
/** | ||
* A function that returns HTTP headers to be used for a route. These headers | ||
* will be merged with (and take precedence over) headers from parent routes. | ||
*/ | ||
export interface HeadersFunction { | ||
(args: HeadersArgs): Headers | HeadersInit; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moved to the ssr
routeModules.ts
file
type LdJsonObject = { [Key in string]: LdJsonValue } & { | ||
[Key in string]?: LdJsonValue | undefined; | ||
}; | ||
type LdJsonArray = LdJsonValue[] | readonly LdJsonValue[]; | ||
type LdJsonPrimitive = string | number | boolean | null; | ||
type LdJsonValue = LdJsonPrimitive | LdJsonObject | LdJsonArray; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed - dupe of the ssr version
/** | ||
* An arbitrary object that is associated with a route. | ||
*/ | ||
export type RouteHandle = unknown; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed - dupe of the ssr version
meta?: MetaFunction; | ||
} | ||
|
||
export interface ServerRouteModule extends EntryRouteModule { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moved to the ssr version
🤖 Hello there, We just published version Thanks! |
🤖 Hello there, We just published version Thanks! |
No description provided.