-
-
Notifications
You must be signed in to change notification settings - Fork 10.6k
feat(react-router): support custom elements as form submitter #13251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Hi @nowells, Welcome, and thank you for contributing to React Router! Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once. You may review the CLA and sign it by adding your name to contributors.yml. Once the CLA is signed, the If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at hello@remix.run. Thanks! - The Remix team |
Right now react-router does not support component libraries that leverage custom-elements that implement the form participation api. This expands the guards checks to allow these form submit elements to function.
0ea1c86
to
cad407a
Compare
Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳 |
@nowells - curious as I'm learning, what component libraries have you used where you ran into this issue? Future readers, found this doc on Form Participation API by google eng folks |
I'm wondering if we can get some 👀 on this? We have a home-grown component library at my work that uses custom elements, and I would love to be able to use react-router un-patched. |
Right now react-router does not support component libraries that leverage custom-elements that implement the form participation api. This expands the guards checks to allow these form submit elements to function.