Skip to content

chore: export DefineRouteFunction type from remix adapter #13614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

chore: export DefineRouteFunction type from remix adapter #13614

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
02cb033
chore: export `DefineRouteFunction` type from remix adapter
bmsuseluda May 15, 2025
f941aed
Create brave-buttons-build.md
bmsuseluda May 15, 2025
72f07ce
Update contributors.yml
bmsuseluda May 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/brave-buttons-build.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@react-router/remix-routes-option-adapter": patch
---

chore: export `DefineRouteFunction` type from remix adapter
1 change: 1 addition & 0 deletions contributors.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@
- BDomzalski
- bhbs
- bilalk711
- bmsuseluda
- bobziroll
- bravo-kernel
- Brendonovich
Expand Down
2 changes: 1 addition & 1 deletion packages/react-router-remix-routes-option-adapter/defineRoutes.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ interface DefineRouteChildren {
(): void;
}

interface DefineRouteFunction {
export interface DefineRouteFunction {
(
/**
* The path this route uses to match the URL pathname.
Expand Down
4 changes: 2 additions & 2 deletions packages/react-router-remix-routes-option-adapter/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
import { type RouteConfigEntry } from "@react-router/dev/routes";

import { routeManifestToRouteConfig } from "./manifest";
import { defineRoutes, type DefineRoutesFunction } from "./defineRoutes";
import { defineRoutes, type DefineRoutesFunction, type DefineRouteFunction } from "./defineRoutes";

export type { DefineRoutesFunction };
export type { DefineRoutesFunction, DefineRouteFunction };

/**
* Adapts routes defined using [Remix's `routes` config
Expand Down