Skip to content

Revert tsup changes from build #13667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 25, 2025

Conversation

brophdawg11
Copy link
Contributor

@brophdawg11 brophdawg11 commented May 24, 2025

While this seemed to work fine for dev we found that it causes some issues in our RSC work, so until we have time to dig into those and ensure this doesn't block any of that work, we're reverting and will re-implement in an upcoming release.

Reverts #13567
Reopens #13076

Copy link

changeset-bot bot commented May 24, 2025

🦋 Changeset detected

Latest commit: 7312d99

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 11 packages
Name Type
react-router Patch
@react-router/architect Patch
@react-router/cloudflare Patch
@react-router/dev Patch
react-router-dom Patch
@react-router/express Patch
@react-router/node Patch
@react-router/serve Patch
@react-router/fs-routes Patch
@react-router/remix-routes-option-adapter Patch
create-react-router Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@brophdawg11 brophdawg11 merged commit 1f54134 into release-next May 25, 2025
10 of 11 checks passed
@brophdawg11 brophdawg11 deleted the brophdawg11/revert-tsup-changes branch May 25, 2025 13:24
Copy link
Contributor

🤖 Hello there,

We just published version 7.6.1-pre.2 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Copy link
Contributor

🤖 Hello there,

We just published version 7.6.1 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants