Enable rsc error test #13696
Enable rsc error test #13696
Conversation
jacob-ebey
commented
May 27, 2025
jacob-ebey
commented
- wait on /favicon for integration test startup
- serve public assets in parcel rsc integration test fixture
- enable rsc error test for parcel
- serve public assets in parcel rsc integration test fixture - enable rsc error test for parcel
|
integration/rsc/rsc-test.ts
Outdated
| @@ -534,11 +534,20 @@ implementations.forEach((implementation) => { | |||
|
|
|||
| test.describe("Errors", () => { | |||
| // FIXME: Unsure why these fail currently | |||
There was a problem hiding this comment.
This comment needs to be removed now?
| @@ -463,7 +463,7 @@ async function waitForServer( | |||
|
|
|||
| await waitOn({ | |||
| resources: [ | |||
| `http://${args.host ?? "localhost"}:${args.port}${args.basename ?? "/"}`, | |||
| `http://${args.host ?? "localhost"}:${args.port}${args.basename ?? "/favicon.ico"}`, | |||
There was a problem hiding this comment.
Why did this need to be changed?
There was a problem hiding this comment.
The underlying logic for detecting "has the server started" seems to need a "success" status code. The test never starts because it responds with a 500. We should always have a favicon though, so just test start against it instead of app logic.
