Skip to content

Conversation

@timdorr
Copy link
Member

@timdorr timdorr commented Jun 5, 2025

@changeset-bot
Copy link

changeset-bot bot commented Jun 5, 2025

⚠️ No Changeset found

Latest commit: a10bc20

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@timdorr timdorr merged commit 259c145 into dev Jun 5, 2025
5 checks passed
@timdorr timdorr deleted the timdorr-fix-dedupe-action branch June 5, 2025 22:15
@MichaelDeBoey
Copy link
Member

@timdorr It seems like there's still something wrong 🤔
https://github.com/remix-run/react-router/actions/runs/15479571414/job/43582659081

Maybe @brophdawg11 or @markdalgleish have any idea?

timdorr added a commit that referenced this pull request Jun 6, 2025
This doesn't fix #13753 or #13756, but should get rid of some errant messaging that is misleading.
timdorr added a commit that referenced this pull request Jun 6, 2025
fix #13753 or #13756, but should get rid of some errant messaging that is misleading.
@brophdawg11
Copy link
Contributor

Is the format action working correctly? I think I added the protection rules a few weeks back when I noticed nothing was protected. I just gave the bot access to bypass the checks so I think that should fix it

Screenshot 2025-06-23 at 11 05 04 AM

@MichaelDeBoey
Copy link
Member

@brophdawg11 It seems like the dedupe workflow still has an error, but I can't seem to figure out what's causing the problem

https://github.com/remix-run/react-router/actions/runs/15979809050/job/45071333446

@brophdawg11
Copy link
Contributor

I think we may just be missing the token on the checkout which should give this access to push past the protected branch checks like the format workflow can? Let's see if this fixes it: 442278d

@MichaelDeBoey
Copy link
Member

@brophdawg11 Not sure if that fixed it or there was nothing to dedupe anymore, but CI passed after merging #13758

https://github.com/remix-run/react-router/actions/runs/16003234491

@brophdawg11
Copy link
Contributor

yeah that one looks like it didn't have any deduping to do so we'll have to keep an eye the next time it changes

@MichaelDeBoey
Copy link
Member

MichaelDeBoey commented Jul 1, 2025

@brophdawg11 It seems that CI worked after merging #13912

https://github.com/remix-run/react-router/actions/runs/16008788710/job/45161531372
17ff101

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants