-
-
Notifications
You must be signed in to change notification settings - Fork 10.8k
Attempt to fix the deduplicate-lock-file action #13756
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Here's the most recent run failure: https://github.com/remix-run/react-router/actions/runs/15478040730/job/43578103541 I'm trying to mirror what the format action does: https://github.com/remix-run/react-router/blob/main/.github/workflows/format.yml#L44-L45 Let's see if this works...
|
|
@timdorr It seems like there's still something wrong 🤔 Maybe @brophdawg11 or @markdalgleish have any idea? |
|
@brophdawg11 It seems like the dedupe workflow still has an error, but I can't seem to figure out what's causing the problem https://github.com/remix-run/react-router/actions/runs/15979809050/job/45071333446 |
|
I think we may just be missing the token on the checkout which should give this access to push past the protected branch checks like the |
|
@brophdawg11 Not sure if that fixed it or there was nothing to dedupe anymore, but CI passed after merging #13758 https://github.com/remix-run/react-router/actions/runs/16003234491 |
|
yeah that one looks like it didn't have any deduping to do so we'll have to keep an eye the next time it changes |
|
@brophdawg11 It seems that CI worked after merging #13912 https://github.com/remix-run/react-router/actions/runs/16008788710/job/45161531372 |

Follows on from #13753
Here's the most recent run failure: https://github.com/remix-run/react-router/actions/runs/15478040730/job/43578103541
I'm trying to mirror what the format action does: https://github.com/remix-run/react-router/blob/main/.github/workflows/format.yml#L44-L45
Let's see if this works...