-
-
Notifications
You must be signed in to change notification settings - Fork 10.7k
fix: handle navigation when browser storage is blocked #14335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: handle navigation when browser storage is blocked #14335
Conversation
🦋 Changeset detectedLatest commit: 82b6b59 The changes in this PR will be included in the next version bump. This PR includes changesets to release 11 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
🤖 Hello there, We just published version Thanks! |
🤖 Hello there, We just published version Thanks! |
Fixes: #14325
Fixes navigation errors that occur when browser storage (localStorage/sessionStorage) is blocked for any reason.
(In my case, I confirmed this occurs when “Do not save data” is enabled in Chrome.)
Problem
When users block cookies/storage in their browser settings, React Router v7 throws an unhandled
SecurityError
during client-side navigation, causing the application to show "Application Error" instead of navigating properly.Solution
Added try-catch blocks around sessionStorage access in
fog-of-war.ts
to handle storage access errors,Test Instructions
Manual Testing
Integration Test
Added integration test in
session-storage-denied-test.ts
that simulates blocked storage and verifies navigation still works.Note
Referencing other catch blocks, I did not add any separate logs or similar to the catch block. I simply left a comment.