fix(react-router-dev): Fix preset future flags merge #14369
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14368
Description
Preset-defined future flags were being completely ignored during configuration resolution. The bug prevented presets from enabling experimental features, which is critical functionality for third-party integrations like (Hydrogen)
Problem
The config resolution was incorrectly reading from
reactRouterUserConfig.future
instead of the mergeduserAndPresetConfigs.future
atpackages/react-router-dev/config/config.ts:589-599
.The merged configuration was already computed earlier (line 440-443):
But the future flags resolution ignored this merged configuration entirely.
Solution
Changed all references from
reactRouterUserConfig.future
touserAndPresetConfigs.future
to properly read from the merged configuration.Testing
integration/vite-presets-test.ts
that verifies preset future flags are properly mergedfalse
)