Skip to content

Conversation

@SailorStat
Copy link
Contributor

Fix unclosed JSX tag in Route component example.

The Route component was missing the closing / which is required in JSX syntax.

Fix unclosed JSX tag in Route component example.

The Route component was missing the closing `/` which is required in JSX syntax.
@changeset-bot
Copy link

changeset-bot bot commented Oct 1, 2025

⚠️ No Changeset found

Latest commit: 972a23b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Oct 1, 2025

Hi @SailorStat,

Welcome, and thank you for contributing to React Router!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at hello@remix.run.

Thanks!

- The Remix team

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Oct 1, 2025

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

Copy link
Contributor

@brophdawg11 brophdawg11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@brophdawg11
Copy link
Contributor

oops - this is actually one of our auto-generated docs, so would you mind making the change in the JSDoc comment instead? https://github.com/remix-run/react-router/blob/main/packages/react-router/lib/components.tsx#L1361

@brophdawg11 brophdawg11 self-requested a review October 1, 2025 14:02
@SailorStat
Copy link
Contributor Author

updated

@brophdawg11 brophdawg11 merged commit 19ac8db into remix-run:main Oct 1, 2025
5 checks passed
@SailorStat SailorStat deleted the patch-1 branch October 2, 2025 06:51
@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2025

🤖 Hello there,

We just published version 7.9.4-pre.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions
Copy link
Contributor

github-actions bot commented Oct 8, 2025

🤖 Hello there,

We just published version 7.9.4 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants