Fix infinite loop in RouteStore.unregisterRoute method

[genbit]

Simple fix

[ryanflorence]

woops! thanks.

[genbit]

@rpflorence no problem :)

Is any way to re-register routes? I want dynamically change routes of my application.

[ryanflorence]

in theory ... we've never done it, you can have multiple "routers" on the page at once. Any time you React.renderComponent(routes, el) it'll register them. The RouteStore data is a single list of routes.

What's the use-case? My mediocre brain can't think of any reason not to declare every route your app responds to up front, primarily because you can potentially link to any part of your app from any other part of your app, how could you ever ensure you aren't linking to an unregistered portion of the app?

[genbit]

@rpflorence for example I want to enable/disable some routes, when user enable/disable some feature in settings, without page refresh.

React.renderComponent(routes, el);

Yes, but looks like routes only are registered on Routes.componentWillMount and they will not be re-registered on render.

I managed to hack it, using the following code:

        RouteStore.unregisterAllRoutes();
        React.Children.forEach(this.getRoutes(), function (child) {
            RouteStore.registerRoute(child);
        });

and small hack in Routes.match method.

but not sure if it's good solution...

https://github.com/genbit/react-router/commit/e3ca7c7221b37c404c66963fa45c6a5470aabc30

[ryanflorence]

why not have your willTransitionTo hooks check some store to see if they are disabled and then redirect? If the user has these routes in their history and use the back button, or saves a link and comes back, I think you'd want to handle it?