enable walking up route hierarchy to trigger onEnter #3197
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I discovered the
onEnter
route hook isn't triggered whenever navigating back up the route hierarchy. This enables triggeringonEnter
when navigating from a child branch to a parent branch.For example, let's take the following routes:
/users/:userId
/users/:userId/assignments/:assignmentId
Navigating from the latter to the former would not trigger
onEnter
when entering the route. This PR alleviates that problem! It will triggeronEnter
when you enter a parent route from a child route and will not re-trigger it if you click it again.