Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not include deprecation code in production builds #3296

Merged
merged 1 commit into from
Apr 13, 2016

Conversation

taion
Copy link
Contributor

@taion taion commented Apr 13, 2016

No description provided.

@taion
Copy link
Contributor Author

taion commented Apr 13, 2016

This just moves the function declaration into the __DEV__ guard; otherwise it ends up in production builds.

@taion taion mentioned this pull request Apr 13, 2016
@timdorr
Copy link
Member

timdorr commented Apr 13, 2016

Saves me the curl https://github.com/taion/rrtr/pull/18.patch | git am :P

👍

@timdorr timdorr merged commit 0c49ccc into remix-run:master Apr 13, 2016
@taion taion deleted the dOP-prod branch April 13, 2016 19:56
@taion
Copy link
Contributor Author

taion commented Apr 13, 2016

Was that what you did? You can actually add that repo as an upstream to your local repo, and git cherry-pick from there.

@timdorr
Copy link
Member

timdorr commented Apr 13, 2016

Given the potential for divergence, I've found it's better to essentially cherry pick that way, rather than build up a "frankenrepo" and a huge .git folder.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants