Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify contextTypes docs #3351

Merged
merged 1 commit into from
Apr 18, 2016
Merged

Clarify contextTypes docs #3351

merged 1 commit into from
Apr 18, 2016

Conversation

taion
Copy link
Contributor

@taion taion commented Apr 18, 2016

No description provided.

@taion
Copy link
Contributor Author

taion commented Apr 18, 2016

I'm not a huge fan of having this on our docs, but this is probably one of the first and maybe only places most devs will see context, so it's not too bad.

@ryanflorence
Copy link
Member

How about we instead remove all of this in favor of #3350 ?

@taion
Copy link
Contributor Author

taion commented Apr 18, 2016

I'm all for that. The only urgency is the es6/ -> es/ change, just to avoid people complaining about somehow breaking semver by changing it back, despite its never having been a public API in the first place.

@taion taion closed this Apr 18, 2016
@taion taion deleted the clarify-contextTypes branch April 18, 2016 21:08
@taion taion restored the clarify-contextTypes branch April 18, 2016 21:16
@taion taion reopened this Apr 18, 2016
@ryanflorence ryanflorence merged commit a48fdd9 into master Apr 18, 2016
@taion taion deleted the clarify-contextTypes branch April 18, 2016 21:19
@lock lock bot locked as resolved and limited conversation to collaborators Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@taion @ryanflorence