Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update API.md #3519

Closed
wants to merge 1 commit into from
Closed

Update API.md #3519

wants to merge 1 commit into from

Conversation

peterbsmyth
Copy link

I think this should be added into the docs because it is available today on the master branch, despite Dan Abramov adding the language in #3444 on the next branch

I think this should be added into the docs because it is available today on the master branch, despite Dan Abramov adding the language in #3444 on the `next` branch
@timdorr
Copy link
Member

timdorr commented Jun 6, 2016

Nope, this isn't currently in master. It'll be on the next major.

@timdorr timdorr closed this Jun 6, 2016
@peterbsmyth
Copy link
Author

How confusing, @gaearon posted this video making use of it. I really thought I was doing something wrong to not be able to use it. Its not great to have a video out using an un-released feature.

@timdorr
Copy link
Member

timdorr commented Jun 7, 2016

He's using the 3.0.0-pre version in the video series, so it's not outdated
once 3.0 goes final.

On Mon, Jun 6, 2016, 9:36 PM Peter B Smith notifications@github.com wrote:

How confusing, @gaearon https://github.com/gaearon posted this video
https://egghead.io/lessons/javascript-redux-using-withrouter-to-inject-the-params-into-connected-components
making use of it. I really thought I was doing something wrong to not be
able to use it. Its not great to have a video out using an un-released
feature.


You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
#3519 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AABF2k1PVgawRWv6sj7BP8nL8AZJTOsVks5qJMsPgaJpZM4IvTXd
.

-Tim

@peterbsmyth
Copy link
Author

@timdorr thanks for following up. I am trying to now make-use-of the feature in my own local project to follow along with the video. My thought is to clone down the repo and checkout the next branch and use that. If that sounds nonsensical, I'm interested to know what the best thing to do is.

@taion
Copy link
Contributor

taion commented Jun 7, 2016

npm i react-router@next

@lock lock bot locked as resolved and limited conversation to collaborators Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants