Throw instead of silently failing with history v3 #3571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Curses, why did I release history v2.5.0 before writing this? |
|
There are more duck-type-y ways to make this check, like failing in the transition manager if |
|
Does history 2.5.0 cause the same bug as 3.x? |
|
There is no history 2.5.0. |
|
Push a 2.5.1 :) |
| @@ -91,6 +98,13 @@ const Router = React.createClass({ | |||
| let { history } = this.props | |||
| const { routes, children } = this.props | |||
|
|
|||
| invariant( | |||
| !isUnsupportedHistory(history), | |||
| 'You have provided a history object from created with history v3.x. ' + | |||
|
I'll release this tomorrow... about to call it a night and probably should be around in case this breaks people. |
Merged
Closed
1 task
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.