[changed] Skip scroll update if only query has changed

[gaearon]

This is supposed to fix #432, #439.

@mjackson @rpflorence what do you think?

---

Previously, the only way to opt out of scroll updates for a route would be by using ignoreScrollBehavior.
This, however, made it hard to implement arguably the most common use case: resetting scroll when params change and preserving it when only query changes.

This commit completely disables scroll updates when only query has changed.
This provides a reasonable default behavior and leaves ignoreScrollBehavior for more complicated cases.

If you'd rather keep the old behavior and reset scroll on query changes, you can either promote query variables to be route params or reset scroll position yourself in response to query changes in route handler's componentDidUpdate.

[mjackson]

@gaearon This looks great. I agree the default should be to not update the scroll position when only the query has changed.

We have been doing a ton of work on the new-api branch, and we're planning on shipping it very soon (hopefully this weekend). Right now the branch is missing ignoreScrollBehavior entirely (still need to get it in, it was a major refactor) but I'd like to get this in as well.

I'd be happy to integrate this work as well, but was wondering if you might have some time to do it. The underlying arch is very similar to what we had before. Mostly high-level API has changed.

[gaearon]

@mjackson

Unfortunately I'm going to be pretty busy weekend so not sure. I'll have some time next week so if initial new API release doesn't include this, I can bring it back. Let me know!

[ryanflorence]

Thanks, I say ship new api without the feature if none of us get to it and
then bring it in later

On Friday, November 21, 2014, Dan Abramov notifications@github.com wrote:

@mjackson https://github.com/mjackson

Unfortunately I'm going to be pretty busy weekend so not sure. I'll have
some time next week so if initial new API release doesn't include this, I
can bring it back. Let me know!

—
Reply to this email directly or view it on GitHub
#477 (comment).

[gaearon]

Yeah I think people will spend some time porting to new API anyway so we get some time to bring it in

[gaearon]

New API is genius btw. That reduce example makes me break down in tears. First-class nesting shows its true power.

[mjackson]

ok, @gaearon. I didn't want you to feel like we were ignoring you :) Let's go ahead and cut a release and get scrolling worked out next week, then cut another stable.

[gaearon]

Superseded by #522