Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run prettier on commit #5868

Merged
merged 1 commit into from
Jan 13, 2018
Merged

Conversation

pshrmn
Copy link
Contributor

@pshrmn pshrmn commented Jan 12, 2018

This PR adds pretty-quick to automatically run prettier on staged files before committing. There are two choices listed on the prettier site, pretty-quick and lint-staged, but I went with pretty-quick because its config is simpler and I don't think RR needs any other pre-commit linting.

pshrmn referenced this pull request Jan 12, 2018
@mjackson mjackson merged commit f8a1934 into remix-run:master Jan 13, 2018
@mjackson
Copy link
Member

Thanks, @pshrmn! :)

@pshrmn pshrmn deleted the prettier-precommit-pr branch January 13, 2018 01:29
@lock lock bot locked as resolved and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants