Testing v6 w/ React Testing Library Docs #7169

thatzacdavis · 2020-02-26T01:04:29Z

Intro
Basic Test
Links and Navigation
Routes and Redirects

alexkrolick · 2020-03-05T20:19:19Z

docs/advanced-guides/testing/testing-with-react-testing-library.md

+
+```jsx
+test('renders react router header', () => {
+  const { getByText } = render(<Router><App /></Router>);


We're presently recommending people import screen from RTL instead of destructuring the render result. This works better with autocomplete and makes each test a little simpler.

👀 @kentcdodds

Yup, so this would be:

import {screen, render} from '@testing-library/react'; test('renders react router header', () => { render(<Router><App /></Router>); const header = screen.getByText('Welcome to React Router!'); expect(header).toBeInTheDocument(); })

It would be even better to recommend the wrapper option so rerender works as expected:

import {screen, render} from '@testing-library/react'; test('renders react router header', () => { render(<App />, {wrapper: Router}); const header = screen.getByText('Welcome to React Router!'); expect(header).toBeInTheDocument(); })

And then to take it to the next level, there's a custom render: https://testing-library.com/docs/react-testing-library/setup#custom-render

Hope that context is helpful!

I see that in the repo README @alexkrolick but not in the docs site, the destructuring is still there, which is what I've been going off of for a while.

I can definitely update these examples, and I can also put in a PR for the RTL docs.

Sorry, we're still in the process of updating things to the new recommendations. PRs would be appreciated!

No worries, I can definitely help with that.

Thanks for all the help with this! I'll work on some updates for this tonight.

kentcdodds · 2020-03-05T20:24:24Z

docs/advanced-guides/testing/testing-with-react-testing-library.md

+  const { getByText } = render(<Router><App /></Router>);
+
+  const aboutLink = getByText('About');
+  act(() => {


You shouldn't need to use act around fireEvent because it's already wrapped in act.

You should rarely need to use act in regular tests. For more on this: https://kentcdodds.com/blog/fix-the-not-wrapped-in-act-warning

kentcdodds · 2020-03-05T20:25:04Z

docs/advanced-guides/testing/testing-with-react-testing-library.md

+  window.history.replaceState({}, '', '/');
+});
+
+afterEach(cleanup);


Oh yeah, and cleanup is unnecessary and happens automatically now: https://testing-library.com/docs/react-testing-library/api#cleanup

alexkrolick

It looks like there is a parallel effort over here #7154

If there are changes for v6, we'd like to update the RTL recipe here https://testing-library.com/docs/example-react-router

One side note is that in the RTL docs we try to avoid language like "simple", "easy", etc. - not everyone is at the same level or has the same background knowledge. If possible we'd like to avoid making that impression over here as well 😄

thatzacdavis · 2020-03-05T20:37:11Z

@will-t-harris want to join forces on this?

This also moves the `Testing Routes and Redirects` section below `Testing Links and Navigation`

will-t-harris · 2020-03-05T22:08:36Z

It seems that the work you've done covers the little that I got through in #7154, unless I'm missing something. I'd be happy to contribute more, but I'm not sure where to start. My experience with RTL is not very deep.

thatzacdavis · 2020-03-05T22:10:07Z

It seems that the work you've done covers the little that I got through in #7154, unless I'm missing something. I'd be happy to contribute more, but I'm not sure where to start. My experience with RTL is not very deep.

I haven't handled any redirects yet, which you could build off the tests I have if you want.

will-t-harris · 2020-03-05T22:13:37Z

I haven't handled any redirects yet, which you could build off the tests I have if you want.

I can try to make some headway on that this evening -- full disclosure, I've never used redirects with react-router. Happy to learn about them though!

thatzacdavis · 2020-03-05T22:49:55Z

I can try to make some headway on that this evening -- full disclosure, I've never used redirects with react-router. Happy to learn about them though!

Same haha, but we got this 💪

will-t-harris · 2020-03-06T05:15:42Z

I have some edits and additions to the content you've added on this fork so far, but I can't push to the branch -- I think because I'm not a contributor on your fork.

Could you please add me so that I can contribute to this PR?

Edit: I suppose I could branch off of your dev branch and make a PR into this? But that seems much more convoluted

thatzacdavis · 2020-03-06T14:04:50Z

I have some edits and additions to the content you've added on this fork so far, but I can't push to the branch -- I think because I'm not a contributor on your fork.

Could you please add me so that I can contribute to this PR?

Edit: I suppose I could branch off of your dev branch and make a PR into this? But that seems much more convoluted

Just invited you to my fork

will-t-harris · 2020-03-06T17:01:07Z

Added an example of testing a redirect -- not entirely confident that it's a good example, but it's at least a starting point to iterate on.

thatzacdavis · 2020-03-06T18:11:08Z

It looks good to me -- maybe @mjackson can weigh in here?

alexkrolick · 2020-03-06T20:32:18Z

docs/advanced-guides/testing/testing-with-react-testing-library.md


-TODO
+Since we've wrapped our `App` component in the `Router` in our `index.js` file, we do have to wrap it around each of our individual component tests, otherwise `history` will be undefined. If the `Router` had been inside of our `App`, then we would not have to wrap it inside of our tests.


Even though I read the above section about "Adding RR via CRA" I find it a bit confusing to hold all these references in my head. I think it would help to explain the exact structure that is required and when you'll need to wrap with Router, in a general way without referencing the example files.

docs/advanced-guides/testing/testing-with-react-testing-library.md

alexkrolick · 2020-03-06T20:35:47Z

docs/advanced-guides/testing/testing-with-react-testing-library.md

+
+```jsx
+test('<App /> renders successfully', () => {
+  render(<App />, { wrapper: Router });


Should also show the imports - is this a memory router or other kind? What JSDOM setup is required, if any?

(and also show the RTL imports) import {screen, render} from '@testing-library/react'

alexkrolick · 2020-03-06T20:41:24Z

docs/advanced-guides/testing/testing-with-react-testing-library.md

+  const aboutLink = screen.getByText('About');
+  fireEvent.click(aboutLink);
+
+  expect(window.location.pathname).toBe('/about');


This won't be the case if you use an in-memory router (it does not update the window.location). I think there are different opinions about this. The downside of using a "full" router is that JSDOM doesn't give you a way to reset the navigation stack, so if you do something like "go back 3 times" you could end up on a previous test's URL (even if you reset the initial location as described below, the number of items on the stack doesn't reset). On the other hand, memory router doesn't represent what's going in the actual app as well, especially if you have some regular <a> tags mixed in or manual manipulation of the URL.

I'm using MemoryRouter in my tests and using a test component as a the route to redirect to.

const RedirectPage = () => { const [searchParams] = useSearchParams(); const action = searchParams.get("action"); if (!action) return <Navigate to="/" />; return <></>; }; test("Should redirect to the home screen if 'action' query param is missing", async () => { function HomePage() { return <h1>Home</h1>; } const { findByRole } = render( <Router initialEntries={["/redirect"]}> <Routes> <Route path="/" element={<HomePage />} /> <Route path="/redirect" element={<RedirectPage />} /> </Routes> </Router> ); const homePageHeading = await findByRole(/heading/i); expect(homePageHeading).toBeVisible(); });

Yes, if you test the page contents, you can make an assertion. But you can't assert window.location.pathname with MemoryRouter, because it doesn't update that.

This is why I've moved away from using the MemoryRouter and instead I render the same router that's rendered in my source code and interact with window.location directly instead: https://github.com/kentcdodds/bookshelf/blob/d9d70fceaea790dfe57ee5a46c13f9f9cc810675/src/test/app-test-utils.js#L15

Works way better. And I get more confidence out of my tests.

alexkrolick · 2020-03-06T20:57:43Z

docs/advanced-guides/testing/testing-with-react-testing-library.md

+
+```
+
+This test initializes the `MemoryRouter` with an initial path of `/the-old-thing` and verifies that the `RedirectHandler` correctly changes the path to `/the-new-thing`


Will this actually happen with a MemoryRouter? I don't think it updates the location. But you could read from the history object (or not use an in-memory router).

Just checked the docs, you're correct that MemoryRouter won't update window.location.

I'm not sure how to set the equivalent of this

initialEntries={["/the-old-thing"]}

using BrowserRouter, in order to set up for the redirect.

Is it acceptable to directly access history.location for testing purposes?

I don't really know why initialEntries exists (maybe to restore across sessions?). Pushing history and waiting for redirect to result in the new URL seems more realistic to me for web use cases. Again, there are limitations to both approaches. window.location.href = doesn't trigger navigation in JSDOM, for example.

thatzacdavis · 2020-03-07T14:15:01Z

@will-t-harris @alexkrolick How does this redirect test look?

will-t-harris · 2020-03-08T16:23:21Z

docs/advanced-guides/testing/testing-with-react-testing-library.md

+import RedirectHandler from "./RedirectHandler";
+
+it("redirects /the-old-thing to /the-new-thing", () => {
+  window.history.pushState({}, "The Old Thing", "/the-new-thing");


Do we want to pushState() to /the-new-thing at the beginning of the test? It seems to me that if this is how the history is set up, then we aren't really testing whether the redirect is happening.

Am I misunderstanding how pushState is functioning here?

thatzacdavis · 2020-03-08T17:28:40Z

Oh yeah, I definitely messed that up. I'll have to fix that.

…

On Sun, Mar 8, 2020, 12:23 PM Will Harris ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In docs/advanced-guides/testing/testing-with-react-testing-library.md <#7169 (comment)> : > ``` And here we have one method of testing that the redirect is behaving as expected. `RedirectHandler.test.js` ```jsx -import React from 'react' -import {MemoryRouter, Route} from 'react-router-dom' -import { render, fireEvent, screen } from ***@***.***/react'; -import RedirectHandler from './RedirectHandler' +import React from "react"; +import { BrowserRouter } from "react-router-dom"; +import { render } from ***@***.***/react"; +import RedirectHandler from "./RedirectHandler"; + +it("redirects /the-old-thing to /the-new-thing", () => { + window.history.pushState({}, "The Old Thing", "/the-new-thing"); Do we want to pushState() to /the-new-thing at the beginning of the test? It seems to me that if this is how the history is set up, then we aren't really testing whether the redirect is happening. Am I misunderstanding how pushState is functioning here? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#7169>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACFJNBMQD2Q6WG5K4Z3OZATRGPIBLANCNFSM4K3ZHEYQ> .

thatzacdavis · 2020-03-08T19:14:31Z

Since I wrote that test incorrectly it looked like that worked, but alas, putting in a redirect like that does not seem to work.

will-t-harris · 2020-03-11T01:24:42Z

So what is the next step forward with this? Should we go back to using MemoryRouter to force the test to start on a specific route?

If so, how are we supposed to read the current path since MemoryRouter won't update window.location?

Perhaps you have some advice @kentcdodds ?

kentcdodds · 2020-03-11T22:17:49Z

Here's an example of what I do: https://github.com/kentcdodds/react-testing-library-course/blob/f5a5f685eb0ecaec444a4fb923050dca29859a21/src/__tests__/react-router-03.js

There's also full-on integration tests which disregard the router altogether (and therefore are using the browser router that the app renders):

https://github.com/kentcdodds/react-testing-library-course/blob/f5a5f685eb0ecaec444a4fb923050dca29859a21/src/__tests__/app-03.js

So my recommendation is that if you're rendering a router, then yeah, the MemoryRouter is probably best, and you can return the history that you create. Otherwise, render the whole app and navigate around.

kentcdodds · 2020-03-11T22:18:01Z

(This isn't a one or the other either, I suggest people do both).

thatzacdavis · 2020-03-12T15:35:15Z

@will-t-harris I'm swamped this week if you want to jump on anything.

will-t-harris · 2020-03-13T04:52:57Z

@thatzacdavis I will try to get to this over the weekend, this week has me all over the place

stale · 2020-08-19T06:40:33Z

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
You can add the fresh label to prevent me from taking any action.

alexkrolick · 2020-08-19T23:38:09Z

I think this would still be useful - anyone want to take it over?

stale · 2020-11-07T21:00:24Z

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
You can add the fresh label to prevent me from taking any action.

alexkrolick · 2020-11-17T03:50:25Z

If anyone needs it, there is an example on the React Testing Library site:

https://testing-library.com/docs/example-react-router

fzaninotto · 2022-01-18T15:46:04Z

I had problems running several unit tests about routing in my app, and this PR gave me the one thing I missed:

beforeEach(() => {
  window.history.replaceState({}, '', '/');
});

I really think this should appear somewhere in the public documentation.

alexkrolick · 2022-01-19T01:40:26Z

@fzaninotto can you make a PR to add it to the RTL docs?

fzaninotto · 2022-01-19T14:26:37Z

well, isn't it a problem that developers will meet with all testing frameworks? I think it should be part of a "testing with react-router" chapter.

thatzacdavis added 2 commits February 25, 2020 19:59

Add setup, basic test, and link tests

06172a0

Fixing title

8b01244

alexkrolick reviewed Mar 5, 2020

View reviewed changes

kentcdodds reviewed Mar 5, 2020

View reviewed changes

alexkrolick reviewed Mar 5, 2020

View reviewed changes

thatzacdavis added 2 commits March 5, 2020 16:00

Update language used in RTL docs

352bdcc

This also moves the `Testing Routes and Redirects` section below `Testing Links and Navigation`

Update RTL test examples to use screen instead of destructured render

d8a2398

thatzacdavis mentioned this pull request Mar 5, 2020

Examples In Docs Site Use Render Destructuring Instead of screen Import testing-library/testing-library-docs#395

Closed

Use wrapper param in RTL tests to support rerender function

dc28df5

content: edited and added content

ba6825d

will-t-harris added 2 commits March 6, 2020 08:26

content: change test names

4fd1541

content: add basic redirect example

e5f95f1

alexkrolick reviewed Mar 6, 2020

View reviewed changes

docs/advanced-guides/testing/testing-with-react-testing-library.md Outdated Show resolved Hide resolved

alexkrolick reviewed Mar 6, 2020

View reviewed changes

thatzacdavis added 3 commits March 7, 2020 08:57

Rename App to HomePage in RTL testing docs

3533f61

Explicitly show imports per RTL test in examples

6556244

Add working redirect test

5bc9025

refactor RedirectHandler component

995e313

will-t-harris reviewed Mar 8, 2020

View reviewed changes

stale bot added the stale label Aug 19, 2020

stale bot removed the stale label Aug 19, 2020

stale bot added the stale label Nov 7, 2020

stale bot closed this Nov 14, 2020

alexkrolick mentioned this pull request Jul 28, 2021

The first test of example-react-router fails testing-library/testing-library-docs#897

Open


		TODO
		Since we've wrapped our `App` component in the `Router` in our `index.js` file, we do have to wrap it around each of our individual component tests, otherwise `history` will be undefined. If the `Router` had been inside of our `App`, then we would not have to wrap it inside of our tests.


		```

		This test initializes the `MemoryRouter` with an initial path of `/the-old-thing` and verifies that the `RedirectHandler` correctly changes the path to `/the-new-thing`

Testing v6 w/ React Testing Library Docs #7169

Testing v6 w/ React Testing Library Docs #7169

Conversation

thatzacdavis commented Feb 26, 2020 • edited Loading

alexkrolick Mar 5, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

alexkrolick left a comment

Choose a reason for hiding this comment

thatzacdavis commented Mar 5, 2020

will-t-harris commented Mar 5, 2020

thatzacdavis commented Mar 5, 2020

will-t-harris commented Mar 5, 2020

thatzacdavis commented Mar 5, 2020

will-t-harris commented Mar 6, 2020 • edited Loading

thatzacdavis commented Mar 6, 2020

will-t-harris commented Mar 6, 2020

thatzacdavis commented Mar 6, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

alexkrolick Mar 6, 2020 • edited Loading

Choose a reason for hiding this comment

sadsa Sep 8, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

alexkrolick Mar 6, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

alexkrolick Mar 7, 2020 • edited Loading

Choose a reason for hiding this comment

thatzacdavis commented Mar 7, 2020

Choose a reason for hiding this comment

thatzacdavis commented Mar 8, 2020 via email

thatzacdavis commented Mar 8, 2020

will-t-harris commented Mar 11, 2020 • edited Loading

kentcdodds commented Mar 11, 2020

kentcdodds commented Mar 11, 2020

thatzacdavis commented Mar 12, 2020

will-t-harris commented Mar 13, 2020

stale bot commented Aug 19, 2020

alexkrolick commented Aug 19, 2020

stale bot commented Nov 7, 2020

alexkrolick commented Nov 17, 2020

fzaninotto commented Jan 18, 2022

alexkrolick commented Jan 19, 2022

fzaninotto commented Jan 19, 2022

thatzacdavis commented Feb 26, 2020 •

edited

Loading

alexkrolick Mar 5, 2020 •

edited

Loading

will-t-harris commented Mar 6, 2020 •

edited

Loading

alexkrolick Mar 6, 2020 •

edited

Loading

sadsa Sep 8, 2020 •

edited

Loading

alexkrolick Mar 6, 2020 •

edited

Loading

alexkrolick Mar 7, 2020 •

edited

Loading

will-t-harris commented Mar 11, 2020 •

edited

Loading