Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added location param override to Routes #7969

Merged
merged 1 commit into from
Sep 1, 2021

Conversation

fgatti675
Copy link
Contributor

Added the posibility to override the location in the Routes component, like it was possible in Switch in V5.
Useful for implementing logic like in the example:
https://reactrouter.com/web/example/modal-gallery
Specific test added

@chaance
Copy link
Collaborator

chaance commented Aug 23, 2021

See my notes here: #7945

We aren't yet sure this is the right API for v6, but we are committed to solving the underlying need before v1.

@chaance chaance closed this Aug 23, 2021
@chaance chaance reopened this Sep 1, 2021
@chaance
Copy link
Collaborator

chaance commented Sep 1, 2021

Ok, we're adding this back 😄 Fixes #7117

@chaance chaance merged commit fea545d into remix-run:dev Sep 1, 2021
@fgatti675 fgatti675 deleted the added_routes_location branch September 19, 2021 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants