useNavigate
: Get pathname
from useLocation
instead of RouteContext
#7982
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #7880 it looks like
useSearchParams
, when called from a higher level route that renders an outlet, potentially directs to the wrong pathname whensetSearchParams
is called and a user is actually at a nested route.This is actually a problem with
useNavigate
, I believe. When the resultingnavigate
function is called without an explicit pathname, we should stick with the current pathname returned byuseLocation
instead of the pathname constructed in theRouteContext
. This ensures thatnavigate
always directs users to a location with the same pathname they are currently on while only modifying either the hash or search depending on what is passed tonavigate
. BecausesetSearchParams
abstractsnavigate
, this should fix #7880 and makeuseNavigate
more stable in general.