Fix greedy * in route paths #8052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prevents `*` from matching without a preceding `/` in the URL pathname. So e.g. `/users/*` matches `/users/mj` but not `/userstypo`. This also fixes `to="."` in splat routes so they point to the route path *including* the portion of the URL that was matched by the `*`, which also makes `*` more consistent with `:param` since it's treated just the same as any other param. There is however a subtle breaking change if you are using the low-level `match` API, e.g. the `match` object you get back from `matchRoutes()` or `useMatch()`. `match.pathname` in a splat route now includes the full URL pathname that was matched instead of only the portion before the `*`. There is a new variable, `match.pathnameStart` that you can use if you needed this for doing your own route matching. Fixes #7972
Also, remove `pathnameStart` property from `match` objects.
mjackson
force-pushed
the
splat-fixes
branch
from
fae0b28
to
4bf20d7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents
*from matching without a preceding/in the URL pathname. So e.g./users/*matches/users/mjbut not/userstypo.This also fixes
to="."in splat routes so they point to the route path including the portion of the URL that was matched by the*, which also makes*more consistent with:paramsince it's treated just the same as any other param.Breaking changes:
matchobject you get back frommatchRoutes()oruseMatch(),match.pathnamein a splat route now includes the full URL pathname that was matched instead of only the portion before the*. You can strip offparams['*']from the end ofmatch.pathnameif you need the old behavioruseParams()in a descendant<Routes>object no longer returns the params from its ancestor<Routes>. You can persist the params directly if you need the old behaviorFixes #7972