Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Strengthen route typings #9366

Merged
merged 16 commits into from
Sep 30, 2022
Merged

fix: Strengthen route typings #9366

merged 16 commits into from
Sep 30, 2022

Commits on Sep 28, 2022

  1. Add conditional type to RouteObject 

    - RouteObject type should accept either index or children.
    @GuptaSiddhant @brophdawg11
    GuptaSiddhant authored and brophdawg11 committed Sep 28, 2022
    Configuration menu
    Copy the full SHA
    56022e7 View commit details
    Browse the repository at this point in the history

  2. Add contributor

    @GuptaSiddhant @brophdawg11
    GuptaSiddhant authored and brophdawg11 committed Sep 28, 2022
    Configuration menu
    Copy the full SHA
    4c331d0 View commit details
    Browse the repository at this point in the history

  3. Enhance children if index is falsy

    @GuptaSiddhant @brophdawg11
    GuptaSiddhant authored and brophdawg11 committed Sep 28, 2022
    Configuration menu
    Copy the full SHA
    093a5c0 View commit details
    Browse the repository at this point in the history

  4. Throw error in createRoutesFromChildren + test

    @siddhant-gupta-accenture @brophdawg11
    siddhant-gupta-accenture authored and brophdawg11 committed Sep 28, 2022
    Configuration menu
    Copy the full SHA
    d3cdf1a View commit details
    Browse the repository at this point in the history

  5. Update error message

    @siddhant-gupta-accenture @brophdawg11
    siddhant-gupta-accenture authored and brophdawg11 committed Sep 28, 2022
    Configuration menu
    Copy the full SHA
    c7e50a1 View commit details
    Browse the repository at this point in the history

  6. fix: Stengthen route typings top to bottom

    @brophdawg11
    brophdawg11 committed Sep 28, 2022
    Configuration menu
    Copy the full SHA
    e0903d5 View commit details
    Browse the repository at this point in the history

  7. Add test+invariant for index/path combinations

    @brophdawg11
    brophdawg11 committed Sep 28, 2022
    Configuration menu
    Copy the full SHA
    8b6d8ed View commit details
    Browse the repository at this point in the history

  8. Remove duplicate check

    @brophdawg11
    brophdawg11 committed Sep 28, 2022
    Configuration menu
    Copy the full SHA
    e4cc495 View commit details
    Browse the repository at this point in the history

Commits on Sep 29, 2022

  1. Add invariant for index/path to flattenRoutes

    @brophdawg11
    brophdawg11 committed Sep 29, 2022
    Configuration menu
    Copy the full SHA
    5f2a196 View commit details
    Browse the repository at this point in the history

  2. Make children checks consistent

    @brophdawg11
    brophdawg11 committed Sep 29, 2022
    Configuration menu
    Copy the full SHA
    7622a69 View commit details
    Browse the repository at this point in the history

  3. Allow index + path routes

    @brophdawg11
    brophdawg11 committed Sep 29, 2022
    Configuration menu
    Copy the full SHA
    7b7090e View commit details
    Browse the repository at this point in the history

  4. remove data router example changes

    @brophdawg11
    brophdawg11 committed Sep 29, 2022
    Configuration menu
    Copy the full SHA
    7cbacec View commit details
    Browse the repository at this point in the history

  5. Remove createroutesFromChildren test

    @brophdawg11
    brophdawg11 committed Sep 29, 2022
    Configuration menu
    Copy the full SHA
    070abd4 View commit details
    Browse the repository at this point in the history

  6. Fix error message

    @brophdawg11
    brophdawg11 committed Sep 29, 2022
    Configuration menu
    Copy the full SHA
    ac23968 View commit details
    Browse the repository at this point in the history

Commits on Sep 30, 2022

  1. List type props

    @brophdawg11
    brophdawg11 committed Sep 30, 2022
    Configuration menu
    Copy the full SHA
    6d72e41 View commit details
    Browse the repository at this point in the history

  2. add changeset

    @brophdawg11
    brophdawg11 committed Sep 30, 2022
    Configuration menu
    Copy the full SHA
    7bee9dc View commit details
    Browse the repository at this point in the history