Updates to static handler for Remix integration #9511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 51f453a The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
brophdawg11
commented
Oct 27, 2022
| @@ -458,7 +458,7 @@ describe("NavLink using a data router", () => { | |||
| fireEvent.click(screen.getByText("Link to Bar")); | |||
| expect(screen.getByText("Link to Bar").className).toBe("pending"); | |||
|
|
|||
| dfd.resolve(); | |||
| dfd.resolve(null); | |||
There was a problem hiding this comment.
These tests used to return undefined, so make them return null now
brophdawg11
commented
Oct 27, 2022
| @@ -11214,7 +11302,7 @@ describe("a router", () => { | |||
| ); | |||
| }); | |||
|
|
|||
| it("should handle not found routes with a 404 Response", async () => { | |||
| describe("Errors with Status Codes", () => { | |||
There was a problem hiding this comment.
View this section with whitespace hidden, but now instead of returning responses we return a new ErrorWithStatus instance and we align the error messages with what Remix uses
brophdawg11
commented
Oct 27, 2022
| loaderHeaders: {}, | ||
| actionHeaders: {}, | ||
| }; | ||
| throw result.error; |
There was a problem hiding this comment.
No need to put this into a context object, just throw it directly now
GOI17
pushed a commit
to GOI17/react-router
that referenced
this pull request
Nov 15, 2022
* Updates to unstable staticHandler logic for Remix integration * Add changeset * bump bundle * Remove ErrorWithStatus in favor of extended ErrorResponse * update * Update changelog
This was referenced Nov 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates to
createStaticHandlerto streamline and make internal router-thrownErrorResponse's consistent for easier integration into Remix. This also fixes a bug where aloader/actioncould previously returnundefinedwhich causes subsequent issues with hydration and revalidation, so we now throw an error to theerrorElementif this happens. Users can returnnullif they don't need to return any data.Todo: