fix: handle encoding of dynamic params in descendant routes #9589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 1b2e28a The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
brophdawg11
commented
Nov 15, 2022
| parentPathnameBase, | ||
| // Re-encode pathnames that were decoded inside matchRoutes | ||
| navigator.encodeLocation(match.pathnameBase).pathname, | ||
| ]), |
There was a problem hiding this comment.
Need these to be re-encoded so that our pathname.slice(parentPathnameBase.length) call up on line 382 is correct. It's slicing from an encoded location.pathname so needs to be using the length of an encoded parentPathnameBase
mjackson
approved these changes
Nov 17, 2022
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need to re-encode the pathname fields on internal matches for proper matching in descendant routes
Closes #9580, #9604