Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(router): add optional generic Data type to DeferredData #9642

Closed
wants to merge 3 commits into from

Conversation

bennyk8y
Copy link

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Nov 27, 2022

⚠️ No Changeset found

Latest commit: e0785b6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Nov 27, 2022

Hi @bennyk8y,

Welcome, and thank you for contributing to React Router!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at hello@remix.run.

Thanks!

- The Remix team

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Nov 27, 2022

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

@MichaelDeBoey MichaelDeBoey changed the title Add optional generic type to DeferredData feat(router): add optional generic Data type to DeferredData Dec 3, 2022
packages/router/utils.ts Outdated Show resolved Hide resolved
Co-authored-by: Michaël De Boey <info@michaeldeboey.be>
@brophdawg11
Copy link
Contributor

For the time being I'm going to close this out and link to it from #9641 - we'll be looking at data API generics as a whole so will want to make sure we consider all cases - and we can use this for reference when we get there. Thanks for putting this together!

@brophdawg11 brophdawg11 closed this Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants