Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(react-router): add type safety to useActionData & useLoaderData hooks #9670

Conversation

MichaelDeBoey
Copy link
Member

This PR brings these hooks in line with what we have in the Remix repo


#9669 needs to be merged first

@changeset-bot
Copy link

changeset-bot bot commented Dec 3, 2022

⚠️ No Changeset found

Latest commit: d0dba01

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@brophdawg11
Copy link
Contributor

brophdawg11 commented Jan 19, 2023

Doing some housecleaning to start 2023 so I'm going to lose these 2 PRs out until the proposal gets accepted and we can re-open or bring along the changes then 👍

@MichaelDeBoey
Copy link
Member Author

Re-opening because @brophdawg11 started with remix-run/remix#5679

@MichaelDeBoey MichaelDeBoey reopened this Mar 6, 2023
@MichaelDeBoey MichaelDeBoey force-pushed the add-typesafety-to-useActionData-useLoaderData-hooks branch from ca91d46 to 9b3ec57 Compare April 17, 2023 19:55
@MichaelDeBoey MichaelDeBoey force-pushed the add-typesafety-to-useActionData-useLoaderData-hooks branch from 9b3ec57 to d0dba01 Compare April 17, 2023 19:58
@brophdawg11
Copy link
Contributor

Let's hold on this for a bit longer, we have some APIs coming in Remix v3 (which will come through RR) that may or may not make these typings obsolete :). But at the very least we should wait to make sure that anything we do for typings on these functions plays nicely with the upcoming v3 APIs

@brophdawg11
Copy link
Contributor

Closing for now - will re-open if/when we want to add these 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants