Skip to content

Commit

Permalink
Replace all 401 to 403 if user is not the owner
Browse files Browse the repository at this point in the history
  • Loading branch information
chaukhoa97 authored Nov 25, 2022
1 parent ba76231 commit 03dd0ad
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions docs/tutorials/jokes.md
Original file line number Diff line number Diff line change
Expand Up @@ -4631,7 +4631,7 @@ Awesome! We're ready to handle errors and it didn't complicate our happy path on

Oh, and don't you love how just like with the `ErrorBoundary`, it's all contextual? So the rest of the app continues to function just as well. Another point for user experience 💪

You know what, while we're adding catch boundaries. Why don't we improve the `app/routes/jokes/$jokeId.tsx` route a bit by allowing users to delete the joke if they own it. If they don't, we can give them a 403 error in the catch boundary. Unlike the 401 when the user needs to log in first, the 403 error means that although the user has been logged in, what he just attempt is forbidden (delete a joke that is not his).
You know what, while we're adding catch boundaries. Why don't we improve the `app/routes/jokes/$jokeId.tsx` route a bit by allowing users to delete the joke if they own it. If they don't, we can give them a 403 error in the catch boundary.

One thing to keep in mind with `delete` is that HTML forms only support `method="get"` and `method="post"`. They don't support `method="delete"`. So to make sure our form will work with and without JavaScript, it's a good idea to do something like this:

Expand Down Expand Up @@ -4708,7 +4708,7 @@ export const action: ActionFunction = async ({
throw new Response(
"Pssh, nice try. That's not your joke",
{
status: 401,
status: 403,
}
);
}
Expand Down Expand Up @@ -4756,7 +4756,7 @@ export function CatchBoundary() {
</div>
);
}
case 401: {
case 403: {
return (
<div className="error-container">
Sorry, but {params.jokeId} is not your joke.
Expand Down Expand Up @@ -4852,7 +4852,7 @@ export const action: ActionFunction = async ({
throw new Response(
"Pssh, nice try. That's not your joke",
{
status: 401,
status: 403,
}
);
}
Expand Down Expand Up @@ -4902,7 +4902,7 @@ export function CatchBoundary() {
</div>
);
}
case 401: {
case 403: {
return (
<div className="error-container">
Sorry, but {params.jokeId} is not your joke.
Expand Down

0 comments on commit 03dd0ad

Please sign in to comment.