refactor(react): add milliseconds abbreviation (ms) to timeout option

remix-run · Jan 23, 2023 · 040b509 · 040b509
1 parent 90b64b0
commit 040b509
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/packages/remix-react/__tests__/components-test.tsx b/packages/remix-react/__tests__/components-test.tsx
@@ -68,7 +68,7 @@ describe("<LiveReload />", () => {
 
     it("timeout of reload is set to 200ms", () => {
       LiveReload = require("../components").LiveReload;
-      let { container } = render(<LiveReload timeout={200} />);
+      let { container } = render(<LiveReload timeoutMs={200} />);
       expect(container.querySelector("script")).toHaveTextContent(
         "setTimeout( () => remixLiveReloadConnect({ onOpen: () => window.location.reload(), }), 200 );"
       );

diff --git a/packages/remix-react/components.tsx b/packages/remix-react/components.tsx
@@ -1536,11 +1536,11 @@ export const LiveReload =
     ? () => null
     : function LiveReload({
         port = Number(process.env.REMIX_DEV_SERVER_WS_PORT || 8002),
-        timeout = 1000,
+        timeoutMs = 1000,
         nonce = undefined,
       }: {
         port?: number;
-        timeout?: number;
+        timeoutMs?: number;
         /**
          * @deprecated this property is no longer relevant.
          */
@@ -1584,7 +1584,7 @@ export const LiveReload =
                           remixLiveReloadConnect({
                             onOpen: () => window.location.reload(),
                           }),
-                      ${String(timeout)}
+                      ${String(timeoutMs)}
                       );
                     }
                   };